openwrt/package/base-files/files/lib
John Crispin 666659fb31 default_postinst() fix wrong call of group_add
[base-files] default_postinst() fix wrong call of group_add
after 12bae65d07d29854204715cebc1ef1eae237fd9b group_add is
always called. shell scripting can be tricky...

wrong call:
[ -n "$gid" ] && group_exists $name || group_add $name $gid

this leads to a call of 'group_add' when $gid is emtpy, proof:

root@box:~ functionA() { echo A; }
root@box:~ functionB() { echo B; }
root@box:~ VAR=
root@box:~ [ -n "$VAR" ] && functionA || functionB
B
root@box:~ # functionB was called, but VAR is not filled
root@box:~ VAR=filled
root@box:~ [ -n "$VAR" ] && functionA || functionB
A

Signed-off-by: Bastian Bittorf <bittorf@bluebottle.com>

SVN-Revision: 42926
2014-10-15 17:55:13 +00:00
..
functions scripts: fix wrong usage of '==' operator 2014-10-14 12:21:11 +00:00
preinit base-files: make use of new fstools 2014-04-07 15:10:15 +00:00
upgrade sysupgrade: Enable killing of all processes under upgraded 2014-07-10 19:16:27 +00:00
functions.sh default_postinst() fix wrong call of group_add 2014-10-15 17:55:13 +00:00